fix: QA remediation — all 19 audit fixes (C+ → A-)
## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
This commit is contained in:
@@ -1,40 +1,27 @@
|
||||
import Link from 'next/link';
|
||||
|
||||
import { ArrowLeft, Send, CheckCircle } from 'lucide-react';
|
||||
import { ArrowLeft } from 'lucide-react';
|
||||
|
||||
import { createFinanceApi } from '@kit/finance/api';
|
||||
import { formatDate } from '@kit/shared/dates';
|
||||
import { getSupabaseServerClient } from '@kit/supabase/server-client';
|
||||
import { Badge } from '@kit/ui/badge';
|
||||
import { Button } from '@kit/ui/button';
|
||||
import { Card, CardContent, CardHeader, CardTitle } from '@kit/ui/card';
|
||||
import { getTranslations } from 'next-intl/server';
|
||||
|
||||
import { AccountNotFound } from '~/components/account-not-found';
|
||||
import { CmsPageShell } from '~/components/cms-page-shell';
|
||||
import {
|
||||
INVOICE_STATUS_VARIANT,
|
||||
INVOICE_STATUS_LABEL_KEYS,
|
||||
} from '~/lib/status-badges';
|
||||
|
||||
import { MarkPaidButton, SendInvoiceButton } from '../invoice-action-buttons';
|
||||
|
||||
interface PageProps {
|
||||
params: Promise<{ account: string; id: string }>;
|
||||
}
|
||||
|
||||
const STATUS_VARIANT: Record<
|
||||
string,
|
||||
'secondary' | 'default' | 'info' | 'outline' | 'destructive'
|
||||
> = {
|
||||
draft: 'secondary',
|
||||
sent: 'default',
|
||||
paid: 'info',
|
||||
overdue: 'destructive',
|
||||
cancelled: 'destructive',
|
||||
};
|
||||
|
||||
const STATUS_LABEL: Record<string, string> = {
|
||||
draft: 'Entwurf',
|
||||
sent: 'Versendet',
|
||||
paid: 'Bezahlt',
|
||||
overdue: 'Überfällig',
|
||||
cancelled: 'Storniert',
|
||||
};
|
||||
|
||||
const formatCurrency = (amount: unknown) =>
|
||||
new Intl.NumberFormat('de-DE', { style: 'currency', currency: 'EUR' }).format(
|
||||
Number(amount),
|
||||
@@ -42,6 +29,7 @@ const formatCurrency = (amount: unknown) =>
|
||||
|
||||
export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
const { account, id } = await params;
|
||||
const t = await getTranslations('finance');
|
||||
const client = getSupabaseServerClient();
|
||||
|
||||
const { data: acct } = await client
|
||||
@@ -61,7 +49,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
const items = (invoice.items ?? []) as Array<Record<string, unknown>>;
|
||||
|
||||
return (
|
||||
<CmsPageShell account={account} title="Rechnungsdetails">
|
||||
<CmsPageShell account={account} title={t('invoices.detailTitle')}>
|
||||
<div className="flex w-full flex-col gap-6">
|
||||
{/* Back link */}
|
||||
<div>
|
||||
@@ -70,7 +58,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
className="text-muted-foreground hover:text-foreground inline-flex items-center text-sm"
|
||||
>
|
||||
<ArrowLeft className="mr-1 h-4 w-4" />
|
||||
Zurück zu Rechnungen
|
||||
{t('invoices.backToList')}
|
||||
</Link>
|
||||
</div>
|
||||
|
||||
@@ -78,17 +66,17 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
<Card>
|
||||
<CardHeader className="flex flex-row items-center justify-between">
|
||||
<CardTitle>
|
||||
Rechnung {String(invoice.invoice_number ?? '')}
|
||||
{t('invoices.invoiceLabel', { number: String(invoice.invoice_number ?? '') })}
|
||||
</CardTitle>
|
||||
<Badge variant={STATUS_VARIANT[status] ?? 'secondary'}>
|
||||
{STATUS_LABEL[status] ?? status}
|
||||
<Badge variant={INVOICE_STATUS_VARIANT[status] ?? 'secondary'}>
|
||||
{t(INVOICE_STATUS_LABEL_KEYS[status] ?? status)}
|
||||
</Badge>
|
||||
</CardHeader>
|
||||
<CardContent>
|
||||
<dl className="grid grid-cols-2 gap-4 sm:grid-cols-4">
|
||||
<div>
|
||||
<dt className="text-muted-foreground text-sm font-medium">
|
||||
Empfänger
|
||||
{t('invoices.recipient')}
|
||||
</dt>
|
||||
<dd className="mt-1 text-sm font-semibold">
|
||||
{String(invoice.recipient_name ?? '—')}
|
||||
@@ -96,7 +84,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
</div>
|
||||
<div>
|
||||
<dt className="text-muted-foreground text-sm font-medium">
|
||||
Rechnungsdatum
|
||||
{t('invoices.issueDate')}
|
||||
</dt>
|
||||
<dd className="mt-1 text-sm font-semibold">
|
||||
{formatDate(invoice.issue_date)}
|
||||
@@ -104,7 +92,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
</div>
|
||||
<div>
|
||||
<dt className="text-muted-foreground text-sm font-medium">
|
||||
Fälligkeitsdatum
|
||||
{t('invoices.dueDate')}
|
||||
</dt>
|
||||
<dd className="mt-1 text-sm font-semibold">
|
||||
{formatDate(invoice.due_date)}
|
||||
@@ -112,7 +100,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
</div>
|
||||
<div>
|
||||
<dt className="text-muted-foreground text-sm font-medium">
|
||||
Gesamtbetrag
|
||||
{t('invoices.amount')}
|
||||
</dt>
|
||||
<dd className="mt-1 text-sm font-semibold">
|
||||
{invoice.total_amount != null
|
||||
@@ -125,16 +113,10 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
{/* Actions */}
|
||||
<div className="mt-6 flex gap-3">
|
||||
{status === 'draft' && (
|
||||
<Button>
|
||||
<Send className="mr-2 h-4 w-4" />
|
||||
Senden
|
||||
</Button>
|
||||
<SendInvoiceButton invoiceId={id} accountId={acct.id} />
|
||||
)}
|
||||
{(status === 'sent' || status === 'overdue') && (
|
||||
<Button variant="outline">
|
||||
<CheckCircle className="mr-2 h-4 w-4" />
|
||||
Bezahlt markieren
|
||||
</Button>
|
||||
<MarkPaidButton invoiceId={id} accountId={acct.id} />
|
||||
)}
|
||||
</div>
|
||||
</CardContent>
|
||||
@@ -143,26 +125,26 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
{/* Line Items */}
|
||||
<Card>
|
||||
<CardHeader>
|
||||
<CardTitle>Positionen ({items.length})</CardTitle>
|
||||
<CardTitle>{t('invoiceForm.lineItems')} ({items.length})</CardTitle>
|
||||
</CardHeader>
|
||||
<CardContent>
|
||||
{items.length === 0 ? (
|
||||
<p className="text-muted-foreground py-8 text-center text-sm">
|
||||
Keine Positionen vorhanden.
|
||||
{t('invoices.noItems')}
|
||||
</p>
|
||||
) : (
|
||||
<div className="rounded-md border">
|
||||
<table className="w-full text-sm">
|
||||
<div className="overflow-x-auto rounded-md border">
|
||||
<table className="w-full min-w-[640px] text-sm">
|
||||
<thead>
|
||||
<tr className="bg-muted/50 border-b">
|
||||
<th className="p-3 text-left font-medium">
|
||||
Beschreibung
|
||||
<th scope="col" className="p-3 text-left font-medium">
|
||||
{t('invoiceForm.itemDescription')}
|
||||
</th>
|
||||
<th className="p-3 text-right font-medium">Menge</th>
|
||||
<th className="p-3 text-right font-medium">
|
||||
Einzelpreis
|
||||
<th scope="col" className="p-3 text-right font-medium">{t('invoiceForm.quantity')}</th>
|
||||
<th scope="col" className="p-3 text-right font-medium">
|
||||
{t('invoices.unitPriceCol')}
|
||||
</th>
|
||||
<th className="p-3 text-right font-medium">Gesamt</th>
|
||||
<th scope="col" className="p-3 text-right font-medium">{t('invoices.totalCol')}</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
@@ -193,7 +175,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
<tfoot>
|
||||
<tr className="bg-muted/30 border-t">
|
||||
<td colSpan={3} className="p-3 text-right font-medium">
|
||||
Zwischensumme
|
||||
{t('invoiceForm.subtotal')}
|
||||
</td>
|
||||
<td className="p-3 text-right">
|
||||
{formatCurrency(invoice.subtotal ?? 0)}
|
||||
@@ -201,7 +183,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
</tr>
|
||||
<tr>
|
||||
<td colSpan={3} className="p-3 text-right font-medium">
|
||||
MwSt. ({Number(invoice.tax_rate ?? 19)}%)
|
||||
{t('invoiceForm.tax', { rate: Number(invoice.tax_rate ?? 19) })}
|
||||
</td>
|
||||
<td className="p-3 text-right">
|
||||
{formatCurrency(invoice.tax_amount ?? 0)}
|
||||
@@ -209,7 +191,7 @@ export default async function InvoiceDetailPage({ params }: PageProps) {
|
||||
</tr>
|
||||
<tr className="border-t font-semibold">
|
||||
<td colSpan={3} className="p-3 text-right">
|
||||
Gesamtbetrag
|
||||
{t('invoiceForm.total')}
|
||||
</td>
|
||||
<td className="p-3 text-right">
|
||||
{formatCurrency(invoice.total_amount ?? 0)}
|
||||
|
||||
Reference in New Issue
Block a user