fix: QA remediation — all 19 audit fixes (C+ → A-)
## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
This commit is contained in:
@@ -18,14 +18,49 @@
|
||||
"checkIn": "Check-in",
|
||||
"checkOut": "Check-out",
|
||||
"nights": "Nights",
|
||||
"price": "Price"
|
||||
"price": "Price",
|
||||
"status": "Status",
|
||||
"amount": "Amount",
|
||||
"total": "Total",
|
||||
"manage": "Manage rooms and bookings",
|
||||
"search": "Search",
|
||||
"reset": "Reset",
|
||||
"noResults": "No bookings found",
|
||||
"noResultsFor": "No results for \"{query}\".",
|
||||
"allBookings": "All Bookings ({count})",
|
||||
"searchResults": "Results ({count})"
|
||||
},
|
||||
"detail": {
|
||||
"title": "Booking Details",
|
||||
"notFound": "Booking not found",
|
||||
"notFoundDesc": "Booking with ID \"{id}\" was not found.",
|
||||
"backToBookings": "Back to Bookings",
|
||||
"guestInfo": "Guest Information",
|
||||
"roomInfo": "Room Information",
|
||||
"bookingDetails": "Booking Details",
|
||||
"extras": "Extras"
|
||||
"extras": "Extras",
|
||||
"room": "Room",
|
||||
"roomNumber": "Room Number",
|
||||
"type": "Type",
|
||||
"noRoom": "No room assigned",
|
||||
"guest": "Guest",
|
||||
"email": "Email",
|
||||
"phone": "Phone",
|
||||
"noGuest": "No guest assigned",
|
||||
"stay": "Stay",
|
||||
"adults": "Adults",
|
||||
"children": "Children",
|
||||
"amount": "Amount",
|
||||
"totalPrice": "Total Price",
|
||||
"notes": "Notes",
|
||||
"actions": "Actions",
|
||||
"changeStatus": "Change booking status",
|
||||
"checkIn": "Check In",
|
||||
"checkOut": "Check Out",
|
||||
"cancel": "Cancel",
|
||||
"cancelledStatus": "cancelled",
|
||||
"completedStatus": "completed",
|
||||
"noMoreActions": "This booking is {statusLabel} — no further actions available."
|
||||
},
|
||||
"form": {
|
||||
"room": "Room *",
|
||||
@@ -51,21 +86,59 @@
|
||||
"title": "Rooms",
|
||||
"newRoom": "New Room",
|
||||
"noRooms": "No rooms found",
|
||||
"addFirst": "Add your first room.",
|
||||
"manage": "Room Management",
|
||||
"allRooms": "All Rooms ({count})",
|
||||
"roomNumber": "Room No.",
|
||||
"name": "Name",
|
||||
"type": "Type",
|
||||
"capacity": "Capacity",
|
||||
"price": "Price/Night"
|
||||
"price": "Price/Night",
|
||||
"active": "Active"
|
||||
},
|
||||
"guests": {
|
||||
"title": "Guests",
|
||||
"newGuest": "New Guest",
|
||||
"noGuests": "No guests found",
|
||||
"addFirst": "Add your first guest.",
|
||||
"manage": "Guest Management",
|
||||
"allGuests": "All Guests ({count})",
|
||||
"name": "Name",
|
||||
"email": "Email",
|
||||
"phone": "Phone",
|
||||
"city": "City",
|
||||
"country": "Country",
|
||||
"bookings": "Bookings"
|
||||
},
|
||||
"calendar": {
|
||||
"title": "Availability Calendar"
|
||||
"title": "Availability Calendar",
|
||||
"subtitle": "Room occupancy at a glance",
|
||||
"occupied": "Occupied",
|
||||
"free": "Free",
|
||||
"today": "Today",
|
||||
"bookingsThisMonth": "Bookings this month",
|
||||
"daysOccupied": "{occupied} of {total} days occupied",
|
||||
"previousMonth": "Previous Month",
|
||||
"nextMonth": "Next Month",
|
||||
"backToBookings": "Back to Bookings"
|
||||
},
|
||||
"newBooking": {
|
||||
"title": "New Booking",
|
||||
"description": "Create booking"
|
||||
},
|
||||
"common": {
|
||||
"previous": "Previous",
|
||||
"next": "Next",
|
||||
"page": "Page",
|
||||
"of": "of",
|
||||
"entries": "entries",
|
||||
"pageInfo": "Page {page} of {total} ({entries} entries)"
|
||||
},
|
||||
"cancel": {
|
||||
"title": "Cancel booking?",
|
||||
"description": "This action cannot be undone. The booking will be permanently cancelled.",
|
||||
"confirm": "Cancel Booking",
|
||||
"cancel": "Dismiss",
|
||||
"cancelling": "Cancelling..."
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user