zaid.marzguioui/myeasycms-v2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Sign in fails when the next parameter is empty (#261)

Browse Source 
* Refactor sign-in flow to ensure fallback return paths

Updated logic to use fallback values for `returnPath` to prevent potential undefined behavior. Improved consistency in handling default paths during sign-in and redirection processes.
This commit is contained in:
Giancarlo Buomprisco
2025-05-28 08:27:45 +07:00
committed by GitHub
parent 40afecde93
commit cb80e4fdcf
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/web/app/auth/sign-in/page.tsx
View File

@@ -26,7 +26,7 @@ export const generateMetadata = async () => {
};
async function SignInPage({ searchParams }: SignInPageProps) {
const { invite_token: inviteToken, next = '' } = await searchParams;
const { invite_token: inviteToken, next } = await searchParams;
const signUpPath =
pathsConfig.auth.signUp +
@@ -34,7 +34,7 @@ async function SignInPage({ searchParams }: SignInPageProps) {
const paths = {
callback: pathsConfig.auth.callback,
returnPath: next ?? pathsConfig.app.home,
returnPath: next || pathsConfig.app.home,
joinTeam: pathsConfig.app.joinTeam,
};

4
packages/features/auth/src/components/sign-in-methods-container.tsx
View File

@@ -45,8 +45,10 @@ export function SignInMethodsContainer(props: {
router.replace(joinTeamPath);
} else {
const returnPath = props.paths.returnPath || '/home';
// otherwise, we should redirect to the return path
router.replace(props.paths.returnPath);
router.replace(returnPath);
}
};