Refactor function components across multiple files

Function components have been refactored across the codebase. Single export-const arrow function components have been adapted into traditional function declarations. This change provides better stack trace in case of errors and better function and argument names on runtime debugging.
This commit is contained in:
giancarlo
2024-05-05 13:31:40 +07:00
parent de15abb801
commit d7d3693f41
20 changed files with 144 additions and 88 deletions

View File

@@ -4,11 +4,15 @@ import { AtSign, Phone } from 'lucide-react';
const DEFAULT_IMAGE_SIZE = 18;
export const OauthProviderLogoImage: React.FC<{
export function OauthProviderLogoImage({
providerId,
width,
height,
}: {
providerId: string;
width?: number;
height?: number;
}> = ({ providerId, width, height }) => {
}) {
const image = getOAuthProviderLogos()[providerId];
if (typeof image === `string`) {
@@ -25,7 +29,7 @@ export const OauthProviderLogoImage: React.FC<{
}
return <>{image}</>;
};
}
function getOAuthProviderLogos(): Record<string, string | React.ReactNode> {
return {

View File

@@ -12,7 +12,7 @@ import { Trans } from '@kit/ui/trans';
import { AuthErrorAlert } from './auth-error-alert';
import { AuthProviderButton } from './auth-provider-button';
export const OauthProviders: React.FC<{
export function OauthProviders(props: {
inviteToken?: string;
enabledProviders: Provider[];
@@ -20,7 +20,7 @@ export const OauthProviders: React.FC<{
callback: string;
returnPath: string;
};
}> = (props) => {
}) {
const signInWithProviderMutation = useSignInWithProvider();
// we make the UI "busy" until the next page is fully loaded
@@ -102,7 +102,7 @@ export const OauthProviders: React.FC<{
</div>
</>
);
};
}
function getProviderName(providerId: string) {
const capitalize = (value: string) =>

View File

@@ -11,9 +11,11 @@ import type { PasswordSignInSchema } from '../schemas/password-sign-in.schema';
import { AuthErrorAlert } from './auth-error-alert';
import { PasswordSignInForm } from './password-sign-in-form';
export const PasswordSignInContainer: React.FC<{
export function PasswordSignInContainer({
onSignIn,
}: {
onSignIn?: (userId?: string) => unknown;
}> = ({ onSignIn }) => {
}) {
const { captchaToken, resetCaptchaToken } = useCaptchaToken();
const signInMutation = useSignInWithEmailPassword();
const isLoading = signInMutation.isPending;
@@ -47,4 +49,4 @@ export const PasswordSignInContainer: React.FC<{
<PasswordSignInForm onSubmit={onSubmit} loading={isLoading} />
</>
);
};
}

View File

@@ -23,10 +23,13 @@ import { Trans } from '@kit/ui/trans';
import { PasswordSignInSchema } from '../schemas/password-sign-in.schema';
export const PasswordSignInForm: React.FC<{
export function PasswordSignInForm({
onSubmit,
loading,
}: {
onSubmit: (params: z.infer<typeof PasswordSignInSchema>) => unknown;
loading: boolean;
}> = ({ onSubmit, loading }) => {
}) {
const { t } = useTranslation('auth');
const form = useForm<z.infer<typeof PasswordSignInSchema>>({
@@ -129,4 +132,4 @@ export const PasswordSignInForm: React.FC<{
</form>
</Form>
);
};
}

View File

@@ -21,14 +21,17 @@ import { Trans } from '@kit/ui/trans';
import { PasswordSignUpSchema } from '../schemas/password-sign-up.schema';
export const PasswordSignUpForm: React.FC<{
export function PasswordSignUpForm({
onSubmit,
loading,
}: {
onSubmit: (params: {
email: string;
password: string;
repeatPassword: string;
}) => unknown;
loading: boolean;
}> = ({ onSubmit, loading }) => {
}) {
const { t } = useTranslation();
const form = useForm({
@@ -148,4 +151,4 @@ export const PasswordSignUpForm: React.FC<{
</form>
</Form>
);
};
}

View File

@@ -16,11 +16,15 @@ import { Trans } from '@kit/ui/trans';
import { deleteInvitationAction } from '../../server/actions/team-invitations-server-actions';
export const DeleteInvitationDialog: React.FC<{
export function DeleteInvitationDialog({
isOpen,
setIsOpen,
invitationId,
}: {
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
invitationId: number;
}> = ({ isOpen, setIsOpen, invitationId }) => {
}) {
return (
<AlertDialog open={isOpen} onOpenChange={setIsOpen}>
<AlertDialogContent>
@@ -41,7 +45,7 @@ export const DeleteInvitationDialog: React.FC<{
</AlertDialogContent>
</AlertDialog>
);
};
}
function DeleteInvitationForm({
invitationId,

View File

@@ -16,12 +16,17 @@ import { Trans } from '@kit/ui/trans';
import { renewInvitationAction } from '../../server/actions/team-invitations-server-actions';
export const RenewInvitationDialog: React.FC<{
export function RenewInvitationDialog({
isOpen,
setIsOpen,
invitationId,
email,
}: {
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
invitationId: number;
email: string;
}> = ({ isOpen, setIsOpen, invitationId, email }) => {
}) {
return (
<AlertDialog open={isOpen} onOpenChange={setIsOpen}>
<AlertDialogContent>
@@ -45,7 +50,7 @@ export const RenewInvitationDialog: React.FC<{
</AlertDialogContent>
</AlertDialog>
);
};
}
function RenewInvitationForm({
invitationId,

View File

@@ -32,13 +32,19 @@ import { RolesDataProvider } from '../members/roles-data-provider';
type Role = string;
export const UpdateInvitationDialog: React.FC<{
export function UpdateInvitationDialog({
isOpen,
setIsOpen,
invitationId,
userRole,
userRoleHierarchy,
}: {
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
invitationId: number;
userRole: Role;
userRoleHierarchy: number;
}> = ({ isOpen, setIsOpen, invitationId, userRole, userRoleHierarchy }) => {
}) {
return (
<Dialog open={isOpen} onOpenChange={setIsOpen}>
<DialogContent>
@@ -61,7 +67,7 @@ export const UpdateInvitationDialog: React.FC<{
</DialogContent>
</Dialog>
);
};
}
function UpdateInvitationForm({
invitationId,

View File

@@ -9,12 +9,17 @@ import { Trans } from '@kit/ui/trans';
type Role = string;
export const MembershipRoleSelector: React.FC<{
export function MembershipRoleSelector({
roles,
value,
currentUserRole,
onChange,
}: {
roles: Role[];
value: Role;
currentUserRole?: Role;
onChange: (role: Role) => unknown;
}> = ({ roles, value, currentUserRole, onChange }) => {
}) {
return (
<Select value={value} onValueChange={onChange}>
<SelectTrigger data-test={'role-selector-trigger'}>
@@ -39,4 +44,4 @@ export const MembershipRoleSelector: React.FC<{
</SelectContent>
</Select>
);
};
}

View File

@@ -16,12 +16,17 @@ import { Trans } from '@kit/ui/trans';
import { removeMemberFromAccountAction } from '../../server/actions/team-members-server-actions';
export const RemoveMemberDialog: React.FC<{
export function RemoveMemberDialog({
isOpen,
setIsOpen,
teamAccountId,
userId,
}: {
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
teamAccountId: string;
userId: string;
}> = ({ isOpen, setIsOpen, teamAccountId, userId }) => {
}) {
return (
<AlertDialog open={isOpen} onOpenChange={setIsOpen}>
<AlertDialogContent>
@@ -43,7 +48,7 @@ export const RemoveMemberDialog: React.FC<{
</AlertDialogContent>
</AlertDialog>
);
};
}
function RemoveMemberForm({
accountId,

View File

@@ -17,9 +17,7 @@ const roleClassNameBuilder = cva('font-medium capitalize shadow-none', {
},
});
export const RoleBadge: React.FC<{
role: Role;
}> = ({ role }) => {
export function RoleBadge({ role }: { role: Role }) {
// @ts-expect-error: hard to type this since users can add custom roles
const className = roleClassNameBuilder({ role });
const isCustom = !(role in roles);
@@ -31,4 +29,4 @@ export const RoleBadge: React.FC<{
</span>
</Badge>
);
};
}

View File

@@ -32,13 +32,19 @@ import { Trans } from '@kit/ui/trans';
import { TransferOwnershipConfirmationSchema } from '../../schema/transfer-ownership-confirmation.schema';
import { transferOwnershipAction } from '../../server/actions/team-members-server-actions';
export const TransferOwnershipDialog: React.FC<{
export function TransferOwnershipDialog({
isOpen,
setIsOpen,
targetDisplayName,
accountId,
userId,
}: {
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
accountId: string;
userId: string;
targetDisplayName: string;
}> = ({ isOpen, setIsOpen, targetDisplayName, accountId, userId }) => {
}) {
return (
<AlertDialog open={isOpen} onOpenChange={setIsOpen}>
<AlertDialogContent>
@@ -61,7 +67,7 @@ export const TransferOwnershipDialog: React.FC<{
</AlertDialogContent>
</AlertDialog>
);
};
}
function TransferOrganizationOwnershipForm({
accountId,

View File

@@ -32,21 +32,21 @@ import { RolesDataProvider } from './roles-data-provider';
type Role = string;
export const UpdateMemberRoleDialog: React.FC<{
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
userId: string;
teamAccountId: string;
userRole: Role;
userRoleHierarchy: number;
}> = ({
export function UpdateMemberRoleDialog({
isOpen,
setIsOpen,
userId,
teamAccountId,
userRole,
userRoleHierarchy,
}) => {
}: {
isOpen: boolean;
setIsOpen: (isOpen: boolean) => void;
userId: string;
teamAccountId: string;
userRole: Role;
userRoleHierarchy: number;
}) {
return (
<Dialog open={isOpen} onOpenChange={setIsOpen}>
<DialogContent>
@@ -74,7 +74,7 @@ export const UpdateMemberRoleDialog: React.FC<{
</DialogContent>
</Dialog>
);
};
}
function UpdateMemberForm({
userId,