## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
276 lines
8.6 KiB
TypeScript
276 lines
8.6 KiB
TypeScript
'use client';
|
|
|
|
import { useState, useCallback } from 'react';
|
|
|
|
import { useRouter } from 'next/navigation';
|
|
|
|
import { Mail, XCircle, Send } from 'lucide-react';
|
|
import { useTranslations } from 'next-intl';
|
|
|
|
import {
|
|
inviteMemberToPortal,
|
|
revokePortalInvitation,
|
|
} from '@kit/member-management/actions/member-actions';
|
|
import { formatDate } from '@kit/shared/dates';
|
|
import { Badge } from '@kit/ui/badge';
|
|
import { Button } from '@kit/ui/button';
|
|
import { Card, CardContent, CardHeader, CardTitle } from '@kit/ui/card';
|
|
import { useActionWithToast } from '@kit/ui/use-action-with-toast';
|
|
|
|
interface Invitation {
|
|
id: string;
|
|
member_id: string;
|
|
email: string;
|
|
status: string;
|
|
created_at: string;
|
|
expires_at: string;
|
|
accepted_at: string | null;
|
|
}
|
|
|
|
interface MemberOption {
|
|
id: string;
|
|
first_name: string;
|
|
last_name: string;
|
|
email: string | null;
|
|
}
|
|
|
|
interface InvitationsViewProps {
|
|
invitations: Invitation[];
|
|
members: MemberOption[];
|
|
accountId: string;
|
|
account: string;
|
|
}
|
|
|
|
const STATUS_LABELS: Record<string, string> = {
|
|
pending: 'Ausstehend',
|
|
accepted: 'Angenommen',
|
|
revoked: 'Widerrufen',
|
|
expired: 'Abgelaufen',
|
|
};
|
|
|
|
const STATUS_COLORS: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
pending: 'default',
|
|
accepted: 'secondary',
|
|
revoked: 'destructive',
|
|
expired: 'outline',
|
|
};
|
|
|
|
export function InvitationsView({
|
|
invitations,
|
|
members,
|
|
accountId,
|
|
account,
|
|
}: InvitationsViewProps) {
|
|
const t = useTranslations('members');
|
|
const router = useRouter();
|
|
const [showDialog, setShowDialog] = useState(false);
|
|
const [selectedMemberId, setSelectedMemberId] = useState('');
|
|
const [email, setEmail] = useState('');
|
|
|
|
const { execute: executeInvite, isPending: isInviting } = useActionWithToast(
|
|
inviteMemberToPortal,
|
|
{
|
|
successMessage: 'Einladung gesendet',
|
|
onSuccess: () => {
|
|
setShowDialog(false);
|
|
setSelectedMemberId('');
|
|
setEmail('');
|
|
router.refresh();
|
|
},
|
|
},
|
|
);
|
|
|
|
const { execute: executeRevoke, isPending: isRevoking } = useActionWithToast(
|
|
revokePortalInvitation,
|
|
{
|
|
successMessage: 'Einladung widerrufen',
|
|
onSuccess: () => router.refresh(),
|
|
},
|
|
);
|
|
|
|
const handleInvite = useCallback(() => {
|
|
if (!selectedMemberId || !email) return;
|
|
executeInvite({
|
|
memberId: selectedMemberId,
|
|
accountId,
|
|
email,
|
|
});
|
|
}, [executeInvite, selectedMemberId, accountId, email]);
|
|
|
|
const handleRevoke = useCallback(
|
|
(invitationId: string) => {
|
|
if (!window.confirm('Einladung wirklich widerrufen?')) return;
|
|
executeRevoke({ invitationId });
|
|
},
|
|
[executeRevoke],
|
|
);
|
|
|
|
// When a member is selected, pre-fill email
|
|
const handleMemberChange = useCallback(
|
|
(memberId: string) => {
|
|
setSelectedMemberId(memberId);
|
|
const member = members.find((m) => m.id === memberId);
|
|
if (member?.email) {
|
|
setEmail(member.email);
|
|
}
|
|
},
|
|
[members],
|
|
);
|
|
|
|
return (
|
|
<div className="space-y-6">
|
|
{/* Actions */}
|
|
<div className="flex justify-end">
|
|
<Button
|
|
onClick={() => setShowDialog(true)}
|
|
data-test="invite-member-btn"
|
|
>
|
|
<Send className="mr-2 h-4 w-4" />
|
|
Einladung senden
|
|
</Button>
|
|
</div>
|
|
|
|
{/* Send Invitation Dialog */}
|
|
{showDialog && (
|
|
<Card>
|
|
<CardHeader>
|
|
<CardTitle className="flex items-center gap-2">
|
|
<Mail className="h-4 w-4" />
|
|
Einladung senden
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<div className="space-y-4">
|
|
<div>
|
|
<label className="mb-1 block text-sm font-medium">
|
|
Mitglied
|
|
</label>
|
|
<select
|
|
value={selectedMemberId}
|
|
onChange={(e) => handleMemberChange(e.target.value)}
|
|
data-test="invite-member-select"
|
|
className="border-input bg-background flex h-9 w-full rounded-md border px-3 py-1 text-sm"
|
|
>
|
|
<option value="">— Mitglied auswählen —</option>
|
|
{members.map((m) => (
|
|
<option key={m.id} value={m.id}>
|
|
{m.last_name}, {m.first_name}
|
|
{m.email ? ` (${m.email})` : ''}
|
|
</option>
|
|
))}
|
|
</select>
|
|
</div>
|
|
<div>
|
|
<label className="mb-1 block text-sm font-medium">
|
|
E-Mail-Adresse
|
|
</label>
|
|
<input
|
|
type="email"
|
|
value={email}
|
|
onChange={(e) => setEmail(e.target.value)}
|
|
placeholder={t('invitations.emailPlaceholder')}
|
|
data-test="invite-email-input"
|
|
className="border-input bg-background flex h-9 w-full rounded-md border px-3 py-1 text-sm"
|
|
/>
|
|
</div>
|
|
<div className="flex gap-2">
|
|
<Button
|
|
onClick={handleInvite}
|
|
disabled={!selectedMemberId || !email || isInviting}
|
|
data-test="invite-submit-btn"
|
|
>
|
|
{isInviting ? 'Sende...' : 'Einladung senden'}
|
|
</Button>
|
|
<Button variant="outline" onClick={() => setShowDialog(false)}>
|
|
Abbrechen
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</CardContent>
|
|
</Card>
|
|
)}
|
|
|
|
{/* Invitations Table */}
|
|
<Card>
|
|
<CardHeader>
|
|
<CardTitle>Einladungen ({invitations.length})</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
{invitations.length === 0 ? (
|
|
<div className="flex flex-col items-center justify-center rounded-lg border border-dashed p-12 text-center">
|
|
<Mail className="text-muted-foreground mb-4 h-10 w-10" />
|
|
<h3 className="text-lg font-semibold">
|
|
Keine Einladungen vorhanden
|
|
</h3>
|
|
<p className="text-muted-foreground mt-1 text-sm">
|
|
{t('invitations.emptyDescription')}
|
|
</p>
|
|
</div>
|
|
) : (
|
|
<div className="overflow-x-auto rounded-md border">
|
|
<table className="w-full min-w-[640px] text-sm">
|
|
<thead>
|
|
<tr className="bg-muted/50 border-b">
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
E-Mail
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
Status
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
Erstellt
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
Läuft ab
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
Aktionen
|
|
</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{invitations.map((inv) => (
|
|
<tr key={inv.id} className="border-b">
|
|
<td className="p-3">{inv.email}</td>
|
|
<td className="p-3">
|
|
<Badge
|
|
variant={STATUS_COLORS[inv.status] ?? 'secondary'}
|
|
>
|
|
{STATUS_LABELS[inv.status] ?? inv.status}
|
|
</Badge>
|
|
</td>
|
|
<td className="p-3 text-xs">
|
|
{formatDate(inv.created_at)}
|
|
</td>
|
|
<td className="p-3 text-xs">
|
|
{formatDate(inv.expires_at)}
|
|
</td>
|
|
<td className="p-3">
|
|
{inv.status === 'pending' && (
|
|
<Button
|
|
variant="ghost"
|
|
size="sm"
|
|
disabled={isRevoking}
|
|
onClick={() => handleRevoke(inv.id)}
|
|
data-test={`revoke-invitation-${inv.id}`}
|
|
>
|
|
<XCircle className="mr-1 h-4 w-4" />
|
|
Widerrufen
|
|
</Button>
|
|
)}
|
|
</td>
|
|
</tr>
|
|
))}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
)}
|
|
</CardContent>
|
|
</Card>
|
|
</div>
|
|
);
|
|
}
|