## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
190 lines
6.6 KiB
TypeScript
190 lines
6.6 KiB
TypeScript
import Link from 'next/link';
|
|
|
|
import { ArrowLeft, Pencil, Send, Users } from 'lucide-react';
|
|
import { getTranslations } from 'next-intl/server';
|
|
|
|
import { createNewsletterApi } from '@kit/newsletter/api';
|
|
import { getSupabaseServerClient } from '@kit/supabase/server-client';
|
|
import { Badge } from '@kit/ui/badge';
|
|
import { Button } from '@kit/ui/button';
|
|
import { Card, CardContent, CardHeader, CardTitle } from '@kit/ui/card';
|
|
|
|
import { AccountNotFound } from '~/components/account-not-found';
|
|
import { CmsPageShell } from '~/components/cms-page-shell';
|
|
import { StatsCard } from '~/components/stats-card';
|
|
import {
|
|
NEWSLETTER_STATUS_VARIANT,
|
|
NEWSLETTER_STATUS_LABEL_KEYS,
|
|
NEWSLETTER_RECIPIENT_STATUS_VARIANT,
|
|
NEWSLETTER_RECIPIENT_STATUS_LABEL_KEYS,
|
|
} from '~/lib/status-badges';
|
|
|
|
import { DispatchNewsletterButton } from './dispatch-newsletter-button';
|
|
|
|
interface PageProps {
|
|
params: Promise<{ account: string; campaignId: string }>;
|
|
}
|
|
|
|
export default async function NewsletterDetailPage({ params }: PageProps) {
|
|
const { account, campaignId } = await params;
|
|
const client = getSupabaseServerClient();
|
|
const t = await getTranslations('newsletter');
|
|
|
|
const { data: acct } = await client
|
|
.from('accounts')
|
|
.select('id')
|
|
.eq('slug', account)
|
|
.single();
|
|
|
|
if (!acct) return <AccountNotFound />;
|
|
|
|
const api = createNewsletterApi(client);
|
|
|
|
const [newsletter, recipients] = await Promise.all([
|
|
api.getNewsletter(campaignId),
|
|
api.getRecipients(campaignId),
|
|
]);
|
|
|
|
if (!newsletter) return <AccountNotFound />;
|
|
|
|
const status = String(newsletter.status);
|
|
const sentCount = recipients.filter(
|
|
(r: Record<string, unknown>) => r.status === 'sent',
|
|
).length;
|
|
const failedCount = recipients.filter(
|
|
(r: Record<string, unknown>) =>
|
|
r.status === 'failed' || r.status === 'bounced',
|
|
).length;
|
|
|
|
return (
|
|
<CmsPageShell account={account} title={t('detail.title')}>
|
|
<div className="flex w-full flex-col gap-6">
|
|
{/* Back link */}
|
|
<div>
|
|
<Link
|
|
href={`/home/${account}/newsletter`}
|
|
className="text-muted-foreground hover:text-foreground inline-flex items-center text-sm"
|
|
data-test="newsletter-back-link"
|
|
>
|
|
<ArrowLeft className="mr-1 h-4 w-4" />
|
|
{t('detail.backToList')}
|
|
</Link>
|
|
</div>
|
|
|
|
{/* Summary Card */}
|
|
<Card>
|
|
<CardHeader className="flex flex-row items-center justify-between">
|
|
<CardTitle>
|
|
{String(newsletter.subject ?? `(${t('list.noSubject')})`)}
|
|
</CardTitle>
|
|
<div className="flex items-center gap-2">
|
|
{status === 'draft' && (
|
|
<Button asChild variant="outline" size="sm">
|
|
<Link href={`/home/${account}/newsletter/${campaignId}/edit`}>
|
|
<Pencil className="mr-2 h-4 w-4" />
|
|
Bearbeiten
|
|
</Link>
|
|
</Button>
|
|
)}
|
|
<Badge variant={NEWSLETTER_STATUS_VARIANT[status] ?? 'secondary'}>
|
|
{t(NEWSLETTER_STATUS_LABEL_KEYS[status] ?? status)}
|
|
</Badge>
|
|
</div>
|
|
</CardHeader>
|
|
<CardContent>
|
|
<div className="grid grid-cols-1 gap-4 sm:grid-cols-3">
|
|
<StatsCard
|
|
title={t('detail.recipientsSection')}
|
|
value={recipients.length}
|
|
icon={<Users className="h-5 w-5" />}
|
|
/>
|
|
<StatsCard
|
|
title={t('detail.sentCount')}
|
|
value={sentCount}
|
|
icon={<Send className="h-5 w-5" />}
|
|
/>
|
|
<StatsCard
|
|
title={t('detail.failedCount')}
|
|
value={failedCount}
|
|
icon={<Send className="h-5 w-5" />}
|
|
/>
|
|
</div>
|
|
|
|
{/* Actions */}
|
|
{status === 'draft' && (
|
|
<div className="mt-6">
|
|
<DispatchNewsletterButton
|
|
newsletterId={campaignId}
|
|
recipientCount={recipients.length}
|
|
/>
|
|
</div>
|
|
)}
|
|
</CardContent>
|
|
</Card>
|
|
|
|
{/* Recipients Table */}
|
|
<Card>
|
|
<CardHeader>
|
|
<CardTitle>
|
|
{t('detail.recipientsSection')} ({recipients.length})
|
|
</CardTitle>
|
|
</CardHeader>
|
|
<CardContent>
|
|
{recipients.length === 0 ? (
|
|
<p className="text-muted-foreground py-8 text-center text-sm">
|
|
{t('detail.noRecipients')}
|
|
</p>
|
|
) : (
|
|
<div className="overflow-x-auto rounded-md border">
|
|
<table className="w-full min-w-[640px] text-sm">
|
|
<thead>
|
|
<tr className="bg-muted/50 border-b">
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
{t('detail.recipientName')}
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
{t('detail.recipientEmail')}
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
{t('detail.recipientStatus')}
|
|
</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{recipients.map((recipient: Record<string, unknown>) => {
|
|
const rStatus = String(recipient.status ?? 'pending');
|
|
return (
|
|
<tr
|
|
key={String(recipient.id)}
|
|
className="hover:bg-muted/30 border-b"
|
|
>
|
|
<td className="p-3 font-medium">
|
|
{String(recipient.name ?? '—')}
|
|
</td>
|
|
<td className="p-3">
|
|
{String(recipient.email ?? '—')}
|
|
</td>
|
|
<td className="p-3">
|
|
<Badge
|
|
variant={
|
|
NEWSLETTER_RECIPIENT_STATUS_VARIANT[rStatus] ??
|
|
'secondary'
|
|
}
|
|
>
|
|
{t(NEWSLETTER_RECIPIENT_STATUS_LABEL_KEYS[rStatus] ?? rStatus)}
|
|
</Badge>
|
|
</td>
|
|
</tr>
|
|
);
|
|
})}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
)}
|
|
</CardContent>
|
|
</Card>
|
|
</div>
|
|
</CmsPageShell>
|
|
);
|
|
}
|