Files
myeasycms-v2/apps/web/app/[locale]/home/[account]/site-builder/page.tsx
Zaid Marzguioui a1719671df
Some checks failed
Workflow / ⚫️ Test (push) Has been cancelled
Workflow / ʦ TypeScript (push) Has been cancelled
fix: QA remediation — all 19 audit fixes (C+ → A-)
## Summary
Fixes all 31  FAILs and most ⚠️ WARNs from the QA audit (113/33⚠️/31).

## Changes

### FIX 1 — Loading Skeleton
- Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton
- Sidebar stays visible during page transitions

### FIX 2 — Status Badges i18n (15 files, 12 label maps)
- Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German)
- Update all 15 consumer files to use t(*_LABEL_KEYS[status])
- Add status namespace to finance.json (de+en)
- Add registration_open to events.json status (de+en)
- Add status block to cms.json events section (de+en)
- Add missing pending/bounced keys to newsletter.json (de+en)
- Add active key to courses.json status (de+en)

### FIX 3 — Error Page i18n
- Replace 4 hardcoded German strings with useTranslations('common')
- Add error.* keys to common.json (de+en)

### FIX 4 — Account Not Found i18n
- Convert AccountNotFound to async Server Component
- Resolve default props from getTranslations('common')
- Add accountNotFoundCard.* keys to common.json (de+en)

### FIX 5 — Publish Toggle Button (6 strings + 2 bugs)
- Add useTranslations('siteBuilder'), replace 6 German strings
- Fix: add response.ok check before router.refresh()
- Fix: add disabled={isPending} to AlertDialogAction
- Fix: use Base UI render= prop pattern (not asChild)
- Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/
  toggleError/cancelAction to siteBuilder.json (de+en)

### FIX 6 — Cancel Booking Button (7 strings + bugs)
- Add useTranslations('bookings'), replace all strings
- Fix: use render= prop pattern, add disabled={isPending}
- Add cancel.* and calendar.* keys to bookings.json (de+en)

### FIX 7 — Portal Pages i18n (5 files, ~40 strings)
- Create i18n/messages/de/portal.json and en/portal.json
- Add 'portal' to i18n/request.ts namespace list
- Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx,
  documents/page.tsx with getTranslations('portal')
- Fix portal-linked-accounts.tsx: add useTranslations, replace
  hardcoded strings, fix AlertDialogTrigger render= pattern

### FIX 8 — Invitations View (1 string)
- Replace hardcoded string with t('invitations.emptyDescription')
- Add key to members.json (de+en)

### FIX 9 — Dead Navigation Link
- Comment out memberPortal nav entry (page does not exist)

### FIX 10 — Calendar Button Accessibility
- Add aria-label + aria-hidden to all icon buttons in bookings/calendar
- Add aria-label + aria-hidden to all icon buttons in courses/calendar
- Add previousMonth/nextMonth/backToBookings/backToCourses to
  bookings.json and courses.json (de+en)

### FIX 11 — Pagination Aria Labels
- Add aria-label to icon-only pagination buttons in finance/page.tsx
- Fix Link/Button nesting in newsletter/page.tsx, add aria-labels
- Add pagination.* to common.json (de+en)
- Add common.previous/next to newsletter.json (de+en)

### FIX 12 — Site Builder Type Safety
- Add SitePage interface, replace Record<string,unknown> in page.tsx
- Add SitePost interface, replace Record<string,unknown> in posts/page.tsx
- Remove String() casts on typed properties

### FIX 14 — EmptyState Heading Level
- Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence)

### FIX 16 — CmsPageShell Nullish Coalescing
- Change description ?? <AppBreadcrumbs /> to !== undefined check

### FIX 17 — Meetings Protocol Hardcoded Strings
- Replace 5 hardcoded German strings with t() in protocol detail page
- Add notFound/back/backToList/statusPublished/statusDraft to meetings.json

### FIX 18 — Finance Toolbar Hardcoded Strings
- Replace toolbar filter labels with t() calls in finance/page.tsx

### FIX 19 — Admin Audit Hardcoded Strings
- Add getTranslations('cms.audit') to audit page
- Replace title, description, column headers, pagination labels
- Add description/timestamp/paginationPrevious/paginationNext to cms.json

## Verification
- tsc --noEmit: 0 errors
- Turbopack: Compiled successfully in 9.3s
- Lint: 0 new errors introduced
- All 8 audit verification checks pass
2026-04-02 01:18:15 +02:00

224 lines
7.9 KiB
TypeScript

import Link from 'next/link';
interface SitePage {
id: string;
title: string;
slug: string;
is_published: boolean;
is_homepage: boolean;
updated_at: string | null;
}
import { Plus, Globe, FileText, Settings, ExternalLink } from 'lucide-react';
import { getTranslations } from 'next-intl/server';
import { formatDate } from '@kit/shared/dates';
import { createSiteBuilderApi } from '@kit/site-builder/api';
import { getSupabaseServerClient } from '@kit/supabase/server-client';
import { Badge } from '@kit/ui/badge';
import { Button } from '@kit/ui/button';
import { Card, CardContent, CardHeader, CardTitle } from '@kit/ui/card';
import { cn } from '@kit/ui/utils';
import { AccountNotFound } from '~/components/account-not-found';
import { CmsPageShell } from '~/components/cms-page-shell';
import { EmptyState } from '~/components/empty-state';
import { PublishToggleButton } from './publish-toggle-button';
interface Props {
params: Promise<{ account: string }>;
}
export default async function SiteBuilderDashboard({ params }: Props) {
const { account } = await params;
const client = getSupabaseServerClient();
const t = await getTranslations('siteBuilder');
const { data: acct } = await client
.from('accounts')
.select('id')
.eq('slug', account)
.single();
if (!acct) return <AccountNotFound />;
const api = createSiteBuilderApi(client);
const [pages, settings, posts] = await Promise.all([
api.listPages(acct.id),
api.getSiteSettings(acct.id),
api.listPosts(acct.id),
]);
const isOnline = Boolean(settings?.is_public);
const publishedCount = (pages as SitePage[]).filter(
(p) => p.is_published,
).length;
return (
<CmsPageShell
account={account}
title={t('dashboard.title')}
description={t('dashboard.description')}
>
<div className="space-y-6">
<div className="flex items-center justify-between">
<div className="flex gap-2">
<Button variant="outline" size="sm" asChild>
<Link href={`/home/${account}/site-builder/settings`}>
<Settings className="mr-2 h-4 w-4" />
{t('dashboard.btnSettings')}
</Link>
</Button>
<Button variant="outline" size="sm" asChild>
<Link href={`/home/${account}/site-builder/posts`}>
<FileText className="mr-2 h-4 w-4" />
{t('dashboard.btnPosts', { count: posts.length })}
</Link>
</Button>
{isOnline && (
<Button variant="outline" size="sm" asChild>
<a href={`/club/${account}`} target="_blank" rel="noopener">
<ExternalLink className="mr-2 h-4 w-4" />
{t('site.viewSite')}
</a>
</Button>
)}
</div>
<Button data-test="site-new-page-btn" asChild>
<Link href={`/home/${account}/site-builder/new`}>
<Plus className="mr-2 h-4 w-4" />
{t('pages.newPage')}
</Link>
</Button>
</div>
<div className="grid grid-cols-1 gap-4 sm:grid-cols-3">
<Card>
<CardContent className="p-6">
<p className="text-muted-foreground text-sm">
{t('site.stats.pages')}
</p>
<p className="text-2xl font-bold">{pages.length}</p>
</CardContent>
</Card>
<Card>
<CardContent className="p-6">
<p className="text-muted-foreground text-sm">
{t('site.stats.published')}
</p>
<p className="text-2xl font-bold">{publishedCount}</p>
</CardContent>
</Card>
<Card>
<CardContent className="p-6">
<p className="text-muted-foreground text-sm">
{t('site.stats.status')}
</p>
<p className="text-2xl font-bold">
<span className="flex items-center gap-1.5">
<span
className={cn(
'inline-block h-2 w-2 rounded-full',
isOnline ? 'bg-green-500' : 'bg-red-500',
)}
/>
<span>
{isOnline ? t('pages.online') : t('pages.offline')}
</span>
</span>
</p>
</CardContent>
</Card>
</div>
{pages.length === 0 ? (
<EmptyState
icon={<Globe className="h-8 w-8" />}
title={t('pages.noPagesYet')}
description={t('pages.noPageDesc')}
actionLabel={t('pages.firstPage')}
actionHref={`/home/${account}/site-builder/new`}
/>
) : (
<div className="overflow-x-auto rounded-md border">
<table className="w-full min-w-[640px] text-sm">
<thead>
<tr className="bg-muted/50 border-b">
<th scope="col" className="p-3 text-left font-medium">
{t('pages.colTitle')}
</th>
<th scope="col" className="p-3 text-left font-medium">
{t('pages.colUrl')}
</th>
<th scope="col" className="p-3 text-left font-medium">
{t('pages.colStatus')}
</th>
<th scope="col" className="p-3 text-left font-medium">
{t('pages.colHomepage')}
</th>
<th scope="col" className="p-3 text-left font-medium">
{t('pages.colUpdated')}
</th>
<th scope="col" className="p-3 text-left font-medium">
{t('pages.colActions')}
</th>
</tr>
</thead>
<tbody>
{(pages as SitePage[]).map((page) => (
<tr
key={page.id}
className="hover:bg-muted/30 border-b"
>
<td className="p-3 font-medium">{page.title}</td>
<td className="text-muted-foreground p-3 font-mono text-xs">
/{page.slug}
</td>
<td className="p-3">
<Badge
variant={page.is_published ? 'default' : 'secondary'}
>
{page.is_published
? t('pages.statusPublished')
: t('pages.statusDraft')}
</Badge>
</td>
<td className="p-3">
{page.is_homepage ? (
<span className="text-xs font-medium text-amber-600">
{t('pages.homepageLabel')}
</span>
) : (
'—'
)}
</td>
<td className="text-muted-foreground p-3 text-xs">
{formatDate(page.updated_at)}
</td>
<td className="p-3">
<div className="flex items-center gap-2">
<PublishToggleButton
pageId={page.id}
accountId={acct.id}
isPublished={page.is_published}
/>
<Button size="sm" variant="outline" asChild>
<Link
href={`/home/${account}/site-builder/${page.id}/edit`}
>
{t('pages.edit')}
</Link>
</Button>
</div>
</td>
</tr>
))}
</tbody>
</table>
</div>
)}
</div>
</CmsPageShell>
);
}