a1719671df
## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
235 lines
6.6 KiB
TypeScript
235 lines
6.6 KiB
TypeScript
export const MEMBER_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
active: 'default',
|
|
inactive: 'secondary',
|
|
pending: 'outline',
|
|
resigned: 'destructive',
|
|
excluded: 'destructive',
|
|
};
|
|
|
|
export const MEMBER_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
active: 'status.active',
|
|
inactive: 'status.inactive',
|
|
pending: 'status.pending',
|
|
resigned: 'status.resigned',
|
|
excluded: 'status.excluded',
|
|
};
|
|
|
|
export const INVOICE_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
draft: 'outline',
|
|
sent: 'secondary',
|
|
paid: 'default',
|
|
overdue: 'destructive',
|
|
cancelled: 'destructive',
|
|
};
|
|
|
|
export const INVOICE_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
draft: 'status.draft',
|
|
sent: 'status.sent',
|
|
paid: 'status.paid',
|
|
overdue: 'status.overdue',
|
|
cancelled: 'status.cancelled',
|
|
};
|
|
|
|
export const BATCH_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
draft: 'outline',
|
|
submitted: 'secondary',
|
|
processing: 'secondary',
|
|
completed: 'default',
|
|
failed: 'destructive',
|
|
};
|
|
|
|
export const BATCH_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
draft: 'status.draft',
|
|
submitted: 'status.submitted',
|
|
processing: 'status.processing',
|
|
completed: 'status.completed',
|
|
failed: 'status.failed',
|
|
};
|
|
|
|
export const NEWSLETTER_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
draft: 'outline',
|
|
scheduled: 'secondary',
|
|
sending: 'secondary',
|
|
sent: 'default',
|
|
failed: 'destructive',
|
|
};
|
|
|
|
export const NEWSLETTER_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
draft: 'status.draft',
|
|
scheduled: 'status.scheduled',
|
|
sending: 'status.sending',
|
|
sent: 'status.sent',
|
|
failed: 'status.failed',
|
|
};
|
|
|
|
export const EVENT_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
planned: 'outline',
|
|
open: 'secondary',
|
|
full: 'secondary',
|
|
running: 'default',
|
|
completed: 'default',
|
|
cancelled: 'destructive',
|
|
registration_open: 'default',
|
|
};
|
|
|
|
export const EVENT_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
planned: 'status.planned',
|
|
open: 'status.open',
|
|
full: 'status.full',
|
|
running: 'status.running',
|
|
completed: 'status.completed',
|
|
cancelled: 'status.cancelled',
|
|
registration_open: 'status.registration_open',
|
|
};
|
|
|
|
export const COURSE_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
planned: 'outline',
|
|
open: 'default',
|
|
active: 'default',
|
|
running: 'secondary',
|
|
completed: 'secondary',
|
|
cancelled: 'destructive',
|
|
};
|
|
|
|
export const COURSE_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
planned: 'status.planned',
|
|
open: 'status.open',
|
|
active: 'status.active',
|
|
running: 'status.running',
|
|
completed: 'status.completed',
|
|
cancelled: 'status.cancelled',
|
|
};
|
|
|
|
export const APPLICATION_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
submitted: 'outline',
|
|
review: 'secondary',
|
|
approved: 'default',
|
|
rejected: 'destructive',
|
|
};
|
|
|
|
export const APPLICATION_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
submitted: 'status.submitted',
|
|
review: 'status.review',
|
|
approved: 'status.approved',
|
|
rejected: 'status.rejected',
|
|
};
|
|
|
|
export const NEWSLETTER_RECIPIENT_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
pending: 'secondary',
|
|
sent: 'default',
|
|
failed: 'destructive',
|
|
bounced: 'destructive',
|
|
};
|
|
|
|
export const NEWSLETTER_RECIPIENT_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
pending: 'status.pending',
|
|
sent: 'status.sent',
|
|
failed: 'status.failed',
|
|
bounced: 'status.bounced',
|
|
};
|
|
|
|
export const BOOKING_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline' | 'info'
|
|
> = {
|
|
pending: 'secondary',
|
|
confirmed: 'default',
|
|
checked_in: 'info',
|
|
checked_out: 'outline',
|
|
cancelled: 'destructive',
|
|
no_show: 'destructive',
|
|
};
|
|
|
|
export const BOOKING_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
pending: 'status.pending',
|
|
confirmed: 'status.confirmed',
|
|
checked_in: 'status.checked_in',
|
|
checked_out: 'status.checked_out',
|
|
cancelled: 'status.cancelled',
|
|
no_show: 'status.no_show',
|
|
};
|
|
|
|
export const MODULE_STATUS_VARIANT: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
published: 'default',
|
|
draft: 'outline',
|
|
archived: 'secondary',
|
|
};
|
|
|
|
export const MODULE_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
published: 'status.published',
|
|
draft: 'status.draft',
|
|
archived: 'status.archived',
|
|
};
|
|
|
|
export const SITE_PAGE_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
published: 'status.published',
|
|
draft: 'status.draft',
|
|
};
|
|
|
|
export const SITE_POST_STATUS_VARIANT: Record<string, 'default' | 'secondary'> =
|
|
{
|
|
published: 'default',
|
|
draft: 'secondary',
|
|
};
|
|
|
|
export const SITE_POST_STATUS_LABEL_KEYS: Record<string, string> = {
|
|
published: 'status.published',
|
|
draft: 'status.draft',
|
|
};
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Legacy named exports kept for backward-compat during incremental migration.
|
|
// These are DEPRECATED — prefer the *_LABEL_KEYS variants + t() in consumers.
|
|
// ---------------------------------------------------------------------------
|
|
/** @deprecated Use MEMBER_STATUS_LABEL_KEYS + t() */
|
|
export const MEMBER_STATUS_LABEL = MEMBER_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use INVOICE_STATUS_LABEL_KEYS + t() */
|
|
export const INVOICE_STATUS_LABEL = INVOICE_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use BATCH_STATUS_LABEL_KEYS + t() */
|
|
export const BATCH_STATUS_LABEL = BATCH_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use NEWSLETTER_STATUS_LABEL_KEYS + t() */
|
|
export const NEWSLETTER_STATUS_LABEL = NEWSLETTER_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use EVENT_STATUS_LABEL_KEYS + t() */
|
|
export const EVENT_STATUS_LABEL = EVENT_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use COURSE_STATUS_LABEL_KEYS + t() */
|
|
export const COURSE_STATUS_LABEL = COURSE_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use APPLICATION_STATUS_LABEL_KEYS + t() */
|
|
export const APPLICATION_STATUS_LABEL = APPLICATION_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use NEWSLETTER_RECIPIENT_STATUS_LABEL_KEYS + t() */
|
|
export const NEWSLETTER_RECIPIENT_STATUS_LABEL = NEWSLETTER_RECIPIENT_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use BOOKING_STATUS_LABEL_KEYS + t() */
|
|
export const BOOKING_STATUS_LABEL = BOOKING_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use MODULE_STATUS_LABEL_KEYS + t() */
|
|
export const MODULE_STATUS_LABEL = MODULE_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use SITE_PAGE_STATUS_LABEL_KEYS + t() */
|
|
export const SITE_PAGE_STATUS_LABEL = SITE_PAGE_STATUS_LABEL_KEYS;
|
|
/** @deprecated Use SITE_POST_STATUS_LABEL_KEYS + t() */
|
|
export const SITE_POST_STATUS_LABEL = SITE_POST_STATUS_LABEL_KEYS;
|