## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
96 lines
2.3 KiB
TypeScript
96 lines
2.3 KiB
TypeScript
/**
|
|
* App-specific i18n request configuration.
|
|
* Loads translation messages from the app's messages directory.
|
|
*
|
|
* Supports two loading strategies:
|
|
* 1. Single file: messages/${locale}.json (all namespaces in one file)
|
|
* 2. Multiple files: messages/${locale}/*.json (namespaces in separate files for lazy loading)
|
|
*
|
|
*/
|
|
import { getRequestConfig } from 'next-intl/server';
|
|
|
|
import { routing } from '@kit/i18n/routing';
|
|
|
|
// Define the namespaces to load
|
|
const namespaces = [
|
|
'common',
|
|
'auth',
|
|
'account',
|
|
'teams',
|
|
'billing',
|
|
'marketing',
|
|
'cms',
|
|
'verband',
|
|
'members',
|
|
'fischerei',
|
|
'meetings',
|
|
'courses',
|
|
'finance',
|
|
'newsletter',
|
|
'siteBuilder',
|
|
'events',
|
|
'documents',
|
|
'bookings',
|
|
'portal',
|
|
] as const;
|
|
|
|
const isDevelopment = process.env.NODE_ENV === 'development';
|
|
|
|
export default getRequestConfig(async ({ requestLocale }) => {
|
|
// Get the locale from the request (provided by middleware)
|
|
let locale = await requestLocale;
|
|
|
|
// Validate that the locale is supported, fallback to default if not
|
|
if (!locale || !routing.locales.includes(locale as never)) {
|
|
locale = routing.defaultLocale;
|
|
}
|
|
|
|
// Load all namespace files and merge them
|
|
const messages = await loadMessages(locale);
|
|
|
|
return {
|
|
locale,
|
|
messages,
|
|
timeZone: 'UTC',
|
|
onError(error) {
|
|
if (isDevelopment) {
|
|
// Missing translations are expected and should only log an error
|
|
console.warn(`[Dev Only] i18n error: ${error.message}`);
|
|
}
|
|
},
|
|
getMessageFallback(info) {
|
|
return info.key;
|
|
},
|
|
};
|
|
});
|
|
|
|
/**
|
|
* Loads translation messages for all namespaces.
|
|
* Each namespace is loaded from a separate file for better code splitting.
|
|
*/
|
|
async function loadMessages(locale: string) {
|
|
const loadedMessages: Record<string, unknown> = {};
|
|
|
|
// Load each namespace file
|
|
await Promise.all(
|
|
namespaces.map(async (namespace) => {
|
|
try {
|
|
const namespaceMessages = await import(
|
|
`./messages/${locale}/${namespace}.json`
|
|
);
|
|
|
|
loadedMessages[namespace] = namespaceMessages.default;
|
|
} catch (error) {
|
|
console.warn(
|
|
`Failed to load namespace "${namespace}" for locale "${locale}":`,
|
|
error,
|
|
);
|
|
// Set empty object as fallback
|
|
loadedMessages[namespace] = {};
|
|
}
|
|
}),
|
|
);
|
|
|
|
return loadedMessages;
|
|
}
|