## Summary Fixes all 31 ❌ FAILs and most ⚠️ WARNs from the QA audit (113✅/33⚠️/31❌). ## Changes ### FIX 1 — Loading Skeleton - Replace full-screen GlobalLoader with PageBody-scoped animate-pulse skeleton - Sidebar stays visible during page transitions ### FIX 2 — Status Badges i18n (15 files, 12 label maps) - Add *_LABEL_KEYS maps to lib/status-badges.ts (i18n keys instead of German) - Update all 15 consumer files to use t(*_LABEL_KEYS[status]) - Add status namespace to finance.json (de+en) - Add registration_open to events.json status (de+en) - Add status block to cms.json events section (de+en) - Add missing pending/bounced keys to newsletter.json (de+en) - Add active key to courses.json status (de+en) ### FIX 3 — Error Page i18n - Replace 4 hardcoded German strings with useTranslations('common') - Add error.* keys to common.json (de+en) ### FIX 4 — Account Not Found i18n - Convert AccountNotFound to async Server Component - Resolve default props from getTranslations('common') - Add accountNotFoundCard.* keys to common.json (de+en) ### FIX 5 — Publish Toggle Button (6 strings + 2 bugs) - Add useTranslations('siteBuilder'), replace 6 German strings - Fix: add response.ok check before router.refresh() - Fix: add disabled={isPending} to AlertDialogAction - Fix: use Base UI render= prop pattern (not asChild) - Add pages.hide/publish/hideTitle/publishTitle/hideDesc/publishDesc/ toggleError/cancelAction to siteBuilder.json (de+en) ### FIX 6 — Cancel Booking Button (7 strings + bugs) - Add useTranslations('bookings'), replace all strings - Fix: use render= prop pattern, add disabled={isPending} - Add cancel.* and calendar.* keys to bookings.json (de+en) ### FIX 7 — Portal Pages i18n (5 files, ~40 strings) - Create i18n/messages/de/portal.json and en/portal.json - Add 'portal' to i18n/request.ts namespace list - Rewrite portal/page.tsx, invite/page.tsx, profile/page.tsx, documents/page.tsx with getTranslations('portal') - Fix portal-linked-accounts.tsx: add useTranslations, replace hardcoded strings, fix AlertDialogTrigger render= pattern ### FIX 8 — Invitations View (1 string) - Replace hardcoded string with t('invitations.emptyDescription') - Add key to members.json (de+en) ### FIX 9 — Dead Navigation Link - Comment out memberPortal nav entry (page does not exist) ### FIX 10 — Calendar Button Accessibility - Add aria-label + aria-hidden to all icon buttons in bookings/calendar - Add aria-label + aria-hidden to all icon buttons in courses/calendar - Add previousMonth/nextMonth/backToBookings/backToCourses to bookings.json and courses.json (de+en) ### FIX 11 — Pagination Aria Labels - Add aria-label to icon-only pagination buttons in finance/page.tsx - Fix Link/Button nesting in newsletter/page.tsx, add aria-labels - Add pagination.* to common.json (de+en) - Add common.previous/next to newsletter.json (de+en) ### FIX 12 — Site Builder Type Safety - Add SitePage interface, replace Record<string,unknown> in page.tsx - Add SitePost interface, replace Record<string,unknown> in posts/page.tsx - Remove String() casts on typed properties ### FIX 14 — EmptyState Heading Level - Change <h3> to <h2> in empty-state.tsx (WCAG heading sequence) ### FIX 16 — CmsPageShell Nullish Coalescing - Change description ?? <AppBreadcrumbs /> to !== undefined check ### FIX 17 — Meetings Protocol Hardcoded Strings - Replace 5 hardcoded German strings with t() in protocol detail page - Add notFound/back/backToList/statusPublished/statusDraft to meetings.json ### FIX 18 — Finance Toolbar Hardcoded Strings - Replace toolbar filter labels with t() calls in finance/page.tsx ### FIX 19 — Admin Audit Hardcoded Strings - Add getTranslations('cms.audit') to audit page - Replace title, description, column headers, pagination labels - Add description/timestamp/paginationPrevious/paginationNext to cms.json ## Verification - tsc --noEmit: 0 errors - Turbopack: Compiled successfully in 9.3s - Lint: 0 new errors introduced - All 8 audit verification checks pass
228 lines
6.6 KiB
TypeScript
228 lines
6.6 KiB
TypeScript
import { getTranslations } from 'next-intl/server';
|
|
|
|
import { AdminGuard } from '@kit/admin/components/admin-guard';
|
|
import { createModuleBuilderApi } from '@kit/module-builder/api';
|
|
import { formatDateTime } from '@kit/shared/dates';
|
|
import { getSupabaseServerAdminClient } from '@kit/supabase/server-admin-client';
|
|
import { Badge } from '@kit/ui/badge';
|
|
import { Button } from '@kit/ui/button';
|
|
import { PageBody, PageHeader } from '@kit/ui/page';
|
|
|
|
interface SearchParams {
|
|
action?: string;
|
|
table?: string;
|
|
page?: string;
|
|
}
|
|
|
|
interface AdminAuditPageProps {
|
|
searchParams: Promise<SearchParams>;
|
|
}
|
|
|
|
const ACTION_LABELS: Record<string, string> = {
|
|
insert: 'Erstellen',
|
|
update: 'Ändern',
|
|
delete: 'Löschen',
|
|
lock: 'Sperren',
|
|
};
|
|
|
|
const ACTION_COLORS: Record<
|
|
string,
|
|
'default' | 'secondary' | 'destructive' | 'outline'
|
|
> = {
|
|
insert: 'default',
|
|
update: 'secondary',
|
|
delete: 'destructive',
|
|
lock: 'outline',
|
|
};
|
|
|
|
async function AuditPage(props: AdminAuditPageProps) {
|
|
const searchParams = await props.searchParams;
|
|
const client = getSupabaseServerAdminClient();
|
|
const api = createModuleBuilderApi(client);
|
|
const t = await getTranslations('cms.audit');
|
|
|
|
const page = searchParams.page ? parseInt(searchParams.page, 10) : 1;
|
|
|
|
const result = await api.audit.query({
|
|
action: searchParams.action || undefined,
|
|
tableName: searchParams.table || undefined,
|
|
page,
|
|
pageSize: 50,
|
|
});
|
|
|
|
const totalPages = Math.ceil(result.total / result.pageSize);
|
|
|
|
return (
|
|
<PageBody>
|
|
<PageHeader
|
|
title={t('title')}
|
|
description={t('description')}
|
|
/>
|
|
|
|
<div className="space-y-4">
|
|
{/* Filters */}
|
|
<AuditFilters
|
|
currentAction={searchParams.action}
|
|
currentTable={searchParams.table}
|
|
/>
|
|
|
|
{/* Results table */}
|
|
<div className="overflow-x-auto rounded-md border">
|
|
<table className="w-full min-w-[640px] text-sm">
|
|
<thead>
|
|
<tr className="bg-muted/50 border-b">
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
{t('timestamp')}
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
{t('action')}
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
{t('table')}
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
Datensatz-ID
|
|
</th>
|
|
<th scope="col" className="p-3 text-left font-medium">
|
|
Benutzer-ID
|
|
</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{result.data.length === 0 ? (
|
|
<tr>
|
|
<td
|
|
colSpan={5}
|
|
className="text-muted-foreground p-8 text-center"
|
|
>
|
|
Keine Einträge gefunden.
|
|
</td>
|
|
</tr>
|
|
) : (
|
|
result.data.map((entry) => (
|
|
<tr key={entry.id} className="border-b">
|
|
<td className="p-3 text-xs">
|
|
{formatDateTime(entry.created_at)}
|
|
</td>
|
|
<td className="p-3">
|
|
<Badge
|
|
variant={
|
|
ACTION_COLORS[entry.action as string] ?? 'secondary'
|
|
}
|
|
>
|
|
{ACTION_LABELS[entry.action as string] ??
|
|
String(entry.action)}
|
|
</Badge>
|
|
</td>
|
|
<td className="p-3 font-mono text-xs">
|
|
{String(entry.table_name)}
|
|
</td>
|
|
<td className="p-3 font-mono text-xs">
|
|
{String(entry.record_id).slice(0, 8)}...
|
|
</td>
|
|
<td className="p-3 font-mono text-xs">
|
|
{String(entry.user_id).slice(0, 8)}...
|
|
</td>
|
|
</tr>
|
|
))
|
|
)}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
|
|
{/* Pagination */}
|
|
{totalPages > 1 && (
|
|
<div className="flex items-center justify-between">
|
|
<p className="text-muted-foreground text-sm">
|
|
Seite {page} von {totalPages} ({result.total} Einträge)
|
|
</p>
|
|
<div className="flex gap-2">
|
|
{page > 1 && (
|
|
<PaginationLink
|
|
page={page - 1}
|
|
action={searchParams.action}
|
|
table={searchParams.table}
|
|
label={t('paginationPrevious')}
|
|
/>
|
|
)}
|
|
{page < totalPages && (
|
|
<PaginationLink
|
|
page={page + 1}
|
|
action={searchParams.action}
|
|
table={searchParams.table}
|
|
label={t('paginationNext')}
|
|
/>
|
|
)}
|
|
</div>
|
|
</div>
|
|
)}
|
|
</div>
|
|
</PageBody>
|
|
);
|
|
}
|
|
|
|
function AuditFilters({
|
|
currentAction,
|
|
currentTable,
|
|
}: {
|
|
currentAction?: string;
|
|
currentTable?: string;
|
|
}) {
|
|
return (
|
|
<div className="flex flex-wrap items-center gap-3">
|
|
<form className="flex items-center gap-3">
|
|
<select
|
|
name="action"
|
|
defaultValue={currentAction ?? ''}
|
|
className="border-input bg-background flex h-9 rounded-md border px-3 py-1 text-sm shadow-sm"
|
|
>
|
|
<option value="">Alle Aktionen</option>
|
|
<option value="insert">Erstellen</option>
|
|
<option value="update">Ändern</option>
|
|
<option value="delete">Löschen</option>
|
|
<option value="lock">Sperren</option>
|
|
</select>
|
|
|
|
<input
|
|
name="table"
|
|
type="text"
|
|
placeholder="Tabelle filtern..."
|
|
defaultValue={currentTable ?? ''}
|
|
className="border-input bg-background flex h-9 w-48 rounded-md border px-3 py-1 text-sm shadow-sm"
|
|
/>
|
|
|
|
<Button type="submit" variant="outline" size="sm">
|
|
Filtern
|
|
</Button>
|
|
</form>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function PaginationLink({
|
|
page,
|
|
action,
|
|
table,
|
|
label,
|
|
}: {
|
|
page: number;
|
|
action?: string;
|
|
table?: string;
|
|
label: string;
|
|
}) {
|
|
const params = new URLSearchParams();
|
|
params.set('page', String(page));
|
|
if (action) params.set('action', action);
|
|
if (table) params.set('table', table);
|
|
|
|
return (
|
|
<a href={`?${params.toString()}`}>
|
|
<Button variant="outline" size="sm">
|
|
{label}
|
|
</Button>
|
|
</a>
|
|
);
|
|
}
|
|
|
|
export default AdminGuard(AuditPage);
|