Refine warning messages and test feedback

This commit refines the warning text in the 'deleteAccountDescription' in locales and associated Supabase service role warning. Additionally, the E2E test for account deletion has been updated to include a response check for a redirection status, improving the reliability of the test outcome.

apps/e2e/tests/account/account.spec.ts

@@ -56,6 +56,12 @@ test.describe('Account Deletion', () => {
     await account.setup();
     await account.deleteAccount();
 
-    await page.waitForURL('http://localhost:3000');
+    const response = await page.waitForResponse((resp) => {
+      return resp.url().includes('home/settings') &&
+        resp.request().method() === 'POST';
+    });
+
+    // The server should respond with a 303 redirect
+    expect(response.status()).toBe(303);
   });
 });

apps/web/public/locales/en/account.json

@@ -132,7 +132,7 @@
   "dangerZoneDescription": "Some actions cannot be undone. Please be careful.",
   "deleteAccount": "Delete your Account",
   "deletingAccount": "Deleting account. Please wait...",
-  "deleteAccountDescription": "This will delete your account and the organizations you own. Furthermore, we will immediately cancel any active subscriptions. This action cannot be undone. You will be asked to confirm this action in the next step.",
+  "deleteAccountDescription": "This will delete your account and the organizations you own. Furthermore, we will immediately cancel any active subscriptions. This action cannot be undone.",
   "deleteProfileConfirmationInputLabel": "Type DELETE to confirm",
   "deleteAccountErrorHeading": "Sorry, we couldn't delete your account",
   "needsReauthentication": "Reauthentication Required",

packages/supabase/src/get-service-role-key.ts

@@ -10,7 +10,7 @@ export function getServiceRoleKey() {
 
   if (process.env.NODE_ENV !== 'production') {
     console.warn(
-      `[Dev Only] You are using the Supabase Service Role. Make sure it's the right call.`,
+      `[Dev Only] This is a simple warning to let you know you are using the Supabase Service Role. Make sure it's the right call.`,
     );
   }